First pass PipelineGraph UI component #732
Conversation
Add PipelineGraph UI component using elkjs and vx. It does not currently support user interaction (zoom, pan, click, etc.) but this will come in future PRs. Add storybook stories to cover the two main components: - Node: represents a node in the graph (Task or Step) - PipelineGraph: collection of Nodes + Links
tekton-robot
added
the
size/XL
| let StatusIcon; | ||
| if (type === 'Task' || status === 'error') { | ||
| switch (status) { | ||
| case 'error': |
There was a problem hiding this comment.
This reads a little strange, make sense to move status === error to its own conditional above ?
There was a problem hiding this comment.
I had that originally but didn't like the duplication and potential for inconsistency in the icons used, we can have a Task with status 'error' or a Step with status 'error'. Tasks always show an icon, Steps only show icon on error.
Open to any suggestions to clean this up.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
#675
Add PipelineGraph UI component using elkjs and vx.
It does not currently support user interaction (zoom, pan, click, etc.)
but this will come in future PRs.
It also does not currently render steps when the tasks are expanded (see screenshot).
Add storybook stories to cover the two main components:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.